Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add license-checker action that fails when any backported file contains BUSL header into release/1.16.x #18489

Merged

Conversation

hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Aug 16, 2023

Backport

This PR is auto-generated from #18485 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

We want to make sure that we aren't accidentally backporting the BUSL license header into versions of Consul that should remain under MPL through the end of the year.

Testing & Reproduction steps

Run script locally on main where it should fail, identifying files which have the BUSL header, and on release branches such as release/1.16.x where it should succeed since no files have the BUSL header.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/license-checker/locally-game-colt branch 3 times, most recently from 21450d3 to 79482a4 Compare August 16, 2023 18:35
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Aug 16, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2023 18:38 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 16, 2023 18:40 Inactive
…ns BUSL header (#18485)

* Add license-checker action that fails when any backported file contains BUSL header

* Quote echoed variable to retain line breaks

* Add ticket to reference for more details
@nathancoleman nathancoleman force-pushed the backport/license-checker/locally-game-colt branch from 79482a4 to ea8e910 Compare August 16, 2023 19:34
@nathancoleman nathancoleman marked this pull request as ready for review August 16, 2023 19:35
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches source PR

@nathancoleman nathancoleman merged commit 764cbbb into release/1.16.x Aug 16, 2023
104 checks passed
@nathancoleman nathancoleman deleted the backport/license-checker/locally-game-colt branch August 16, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants