NET 6409 #19515
Merged
NET 6409 #19515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
absolutelightning
added
consul-india
2 tasks
david-yu
reviewed
Nov 4, 2023
david-yu
reviewed
Nov 4, 2023
|
Could you also add the command to the Command TOC here? https://consul-7g86tczfl-hashicorp.vercel.app/consul/docs/k8s/k8s-cli#commands |
|
We should also backport to 1.17.x, 1.16.x and 1.15.x |
Co-authored-by: David Yu <[email protected]>
david-yu
reviewed
Nov 6, 2023
Co-authored-by: David Yu <[email protected]>
david-yu
approved these changes
Nov 6, 2023
|
Looks good, we should wait to merge until the next patch release, which should include this in consul-k8s 1.3.x, 1.2.x, and 1.1.x |
david-yu
added
backport/1.15
Please clarify till when we need to wait? |
|
This would roughly be 5 weeks from now for the next set of patch releases. |
This was referenced Dec 18, 2023
|
@absolutelightning Could you resolve the failed docs backports? |
absolutelightning
added a commit
that referenced
this pull request
Dec 19, 2023
* Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> * Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> * fix doc * Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> --------- Co-authored-by: David Yu <[email protected]>
absolutelightning
added a commit
that referenced
this pull request
Dec 19, 2023
* Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> * Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> * fix doc * Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> --------- Co-authored-by: David Yu <[email protected]>
absolutelightning
added a commit
that referenced
this pull request
Dec 19, 2023
* Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> * Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> * fix doc * Update website/content/docs/k8s/k8s-cli.mdx Co-authored-by: David Yu <[email protected]> --------- Co-authored-by: David Yu <[email protected]>
absolutelightning
added a commit
that referenced
this pull request
Dec 19, 2023
NET 6409 (#19515) * Update website/content/docs/k8s/k8s-cli.mdx * Update website/content/docs/k8s/k8s-cli.mdx * fix doc * Update website/content/docs/k8s/k8s-cli.mdx --------- Co-authored-by: Ashesh Vidyut <[email protected]> Co-authored-by: David Yu <[email protected]>
absolutelightning
added a commit
that referenced
this pull request
Dec 19, 2023
NET 6409 (#19515) * Update website/content/docs/k8s/k8s-cli.mdx * Update website/content/docs/k8s/k8s-cli.mdx * fix doc * Update website/content/docs/k8s/k8s-cli.mdx --------- Co-authored-by: Ashesh Vidyut <[email protected]> Co-authored-by: David Yu <[email protected]>
absolutelightning
added a commit
that referenced
this pull request
Dec 19, 2023
NET 6409 (#19515) * Update website/content/docs/k8s/k8s-cli.mdx * Update website/content/docs/k8s/k8s-cli.mdx * fix doc * Update website/content/docs/k8s/k8s-cli.mdx --------- Co-authored-by: Ashesh Vidyut <[email protected]> Co-authored-by: David Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added docs for Consul K8s Proxy Stats Command
Testing & Reproduction steps
Links
PR Checklist