Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update k8s upgrade instructions #20263

Merged
merged 2 commits into from
Jan 18, 2024
Merged

docs: update k8s upgrade instructions #20263

merged 2 commits into from
Jan 18, 2024

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jan 18, 2024

With hashicorp/consul-k8s#3000 merged, users can
upgrade their k8s installs using a regular helm upgrade since the
upgrade is now stable.

@lkysow lkysow added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Jan 18, 2024
@lkysow lkysow requested a review from a team as a code owner January 18, 2024 22:03
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. I made a few style guide related suggestions and had one question. Approving so that you can move forward after you've addressed them.

website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
```

</CodeBlockConfig>

2. Determine the version of your existing Helm installation. In this example, version `0.39.0` (from `consul-k8s:0.39.0`) is being used.
1. Determine the version of your existing Helm installation. In this example, version `0.39.0` (from `consul-k8s:0.39.0`) is being used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Determine the version of your existing Helm installation. In this example, version `0.39.0` (from `consul-k8s:0.39.0`) is being used.
1. Determine the version of your existing Helm installation. The following example shows that version `0.39.0` is installed. The version is derived from the `consul-k8s:0.39.0` image.

It's not clear what the consul-k8s:0.39.0 refers to. I assumed that it is an image version, but please correct me if I'm wrong.

website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
@lkysow
Copy link
Member Author

lkysow commented Jan 18, 2024

Thanks for the quick review @trujillo-adam !

lkysow and others added 2 commits January 18, 2024 15:13
With hashicorp/consul-k8s#3000 merged, users can
upgrade their k8s installs using a regular helm upgrade since the
upgrade is now stable.
@lkysow lkysow enabled auto-merge (squash) January 18, 2024 23:13
@lkysow lkysow merged commit 0cb64cc into main Jan 18, 2024
59 of 60 checks passed
@lkysow lkysow deleted the docs/lkysow/k8s-upgrade branch January 18, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants