Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Prepared Query Using WriteOptions #2417

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

moofish32
Copy link
Contributor

Fixes the issue in #1591 where the Go API for delete prepared query used query options instead of write options

Issues to consider

  • This is a breaking change to the signature, we could create an interface abstraction to support some backwards compatibility
  • Unit tests pass nil instead of an object here, but more testing is done at the lower levels; do we want to add more tests here?

@moofish32
Copy link
Contributor Author

@slackpad -- seems like it's merge week, just bumping the PR

@slackpad slackpad added this to the 0.7.1 milestone Oct 27, 2016
@kyhavlov kyhavlov merged commit cbf2874 into hashicorp:master Nov 3, 2016
@slackpad
Copy link
Contributor

slackpad commented Nov 3, 2016

Thanks @moofish32!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants