Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out left/leaving serf members when determining if new AC… #6332

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Aug 15, 2019

In the scenario where you bring up new servers and shutdown/gracefully leave the old ones the ACL system could get stuck in legacy mode until those other members are reaped.

This filters the members that are considered to just those that are alive or failed.

@mkeeler mkeeler added this to the 1.6.0-final milestone Aug 15, 2019
@mkeeler mkeeler requested a review from a team August 15, 2019 18:59
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@mkeeler mkeeler changed the title Filter out left/leaving serf members when determining if new ACLs can be used. Filter out left/leaving serf members when determining if new AC… Aug 16, 2019
@mkeeler mkeeler merged commit 318b9eb into release/1-6 Aug 16, 2019
@mkeeler mkeeler deleted the bugfix/acl-mode-transition branch August 16, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants