Do not surface left servers #6420
Conversation
hanshasselberg
force-pushed
the
no_left_servers_from_catalog
branch
from
706e7ba
to
fcf8421
Compare
hanshasselberg
force-pushed
the
no_left_servers_from_catalog
branch
from
fcf8421
to
f0cb17f
Compare
hanshasselberg
force-pushed
the
no_left_servers_from_catalog
branch
from
d38f2ee
to
b3eb511
Compare
|
This feels like a small breaking change since the output of an endpoint is changing. Maybe we should get it into 1.7.0 but not 1.6.x? |
|
@freddygv Well, this change the output in very rare occasions (when DC is dead for more than 72 hours or operator did force-leave the servers), so it looks to me like a very reasonable choice that would unlikely break workflows (while helping a lot during decommission). |
|
I agree with @pierresouchay on this one. I think this a bugfix, what would anyone want to do with decommissioned datacenters... And thus I think it would be fine to include it into 1.6.x series. |
|
I noticed the other functions that are returning datacenters and I want to make sure to make them all behave similarly. |
|
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
ghost
locked and limited conversation to collaborators
Left servers will never come back so there is no reason to surface them in
GetDatacentersByDistance. One of the results is that dcs with only left servers will no longer show up inv1/catalog/datacenters, which is the right thing to do since this dc is not reachable.