Add PolicyReadByName for API

[abaez]

While writing an update to the python library consulate for Consul's ACL gmr/consulate#123, I noticed that Consul's API was missing the PolicyReadByName API function. Seeing as how it's fairly simple fix, here's a small patch I made to the API to add the ability. Covers at the read by name issue on #5962 brought up.

Let me know if there's any error or modification I should do here.

[scalp42]

It'd come in handy as we're currently working around the issue by filtering on client side: https://github.com/scalp42/consul-cookbook/blob/scalp42/libraries/consul_policy.rb#L61-L75

[mkeeler]

I think this should be ready now to implement the changes PolicyRead RPC function here

You will want to check if the ID is empty and if so call state.ACLPolicyReadByName instead of state.ACLPolicyReadByID

That should be the last bit to get this functional.

Then all thats needed is a couple tests:

agent/consul/acl_endpoint_test.go - exercise the RPC func to ensure reading by name works. Mostly copy the normal policy read test and change it to lookup the policy by name.

agent/acl_endpoint_test.go - add another subtest similar to this one

[abaez]

Hey @mkeeler,

Thank you so much for the help on getting this ready. Greatly appreciate all the help you provided on this. Let me know if there's anything else you think is required here. Else, I'll go ahead rebase and squash this.

[mkeeler]

@abaez I apologize for letting this linger for so long. This looks good to me now but will require resolving some conflicts with the current master.

It looks like its just the three files github is showing.

1. agent/acl_endpoint.go - your new function is at the same location as another new function. Just take both changes here.
2. agent/consul/acl_endpoint.go - The signature of the ACLPolicyGetByID and ACLPolicyGetByName functions changed slightly. You should just pass through the new &args.EnterpriseMeta in your invocations of the functions.
3. agent/http_oss.go - The HTTP endpoint registrations moved from this file to http_register.go

I know its been a long time and would be willing to fix these conflicts on your branch if you no longer have the time or inclination to do so yourself and then get this merged.

[abaez]

Hey @mkeeler,

Sure I can go ahead and update this during the weekend. And no worries. I know your team is artfully busy. These things happen, even with small changes.

Though wouldn't mind some push on go-discover side.

[abaez]

@i0rek , @mkeeler, can either of you review over the change? I believe it is in good enough shape now for squash and merge.

Let me know if there's anything you need on my end.

[mkeeler]

@abaez Thanks for all your work on this. I am going to approve this but since we have already started the release machinery for v1.7.2 this wont make it in until 1.7.3.