CVE-2020-12758: Service-router config entry with no destination #7783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-ci
pushed a commit
that referenced
this pull request
May 5, 2020
hanshasselberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Requiring service:write permissions, a service-router entry without a destination can crash Consul servers.
Background
Introduced in Consul v1.6.0, a service-router config entry controls Connect traffic routing and manipulation at networking layer 7 (e.g. HTTP). When an entry is created without a destination, requiring an ACL token with service:write permissions, it is possible to crash Consul servers.
Remediation
Steps to remediate: