ui: Add ability to sort service based on health #7989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves custom sorting to use the same pattern as custom searching.
johncowen
added a commit
that referenced
this pull request
Jun 3, 2020
* ui: Add ability to sort service based on health * ui: Move custom sorting to sort/comparator Service/Helper (like search) This moves custom sorting to use the same pattern as custom searching. * Remove old Controller based comparator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to sort Services based on their health.
I would imagine that moving forwards we will potentially need several of these, so I followed the same pattern as our 'searchables' here, which allow us to use pure vanilla javascript to define searching functionality per model.
This gives us a set of 'comparators' (currently there only being one), that we can use in any template/component via the helper in a composable fashion, without the functionality being tied to any one Controller or Mixin.
'Comparators' can either return a simple string or a comparator function, both of which are accepted by the ember-composable-helpers
sort-byhelper.Unit and simple acceptance tests are added here.