CodeBlock - fix line numbers always shown when highlightLines is set
#2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
approved these changes
Oct 2, 2024
jorytindall
approved these changes
Oct 2, 2024
shleewhite
approved these changes
Oct 7, 2024
alex-ju
force-pushed
the
alex-ju/fix-code-block-highlight-lines
branch
from
5c70d8e
to
0f3df00
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Uncouple
hasLineNumbersfromhighlightLines.🛠️ Detailed description
With this change, if
@hasLineNumbers={{false}}we highlight the lines without automatically showing the numbers.Preview in
showcase🔗 External links
Jira ticket: HDS-3348
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.