Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Handling - update tcp dial timeout regex to catch broader range of error conditions #1108

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Error Handling - update tcp dial timeout regex to catch broader range of error conditions #1108

merged 6 commits into from
Oct 25, 2024

Conversation

jackofallops
Copy link
Member

No description provided.

@jackofallops jackofallops requested a review from a team as a code owner October 23, 2024 11:50
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Oct 23, 2024
stephybun
stephybun approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops one question other LGTM 🦒

sdk/client/resourcemanager/poller_provisioning_state.go Show resolved Hide resolved
@jackofallops jackofallops merged commit 3ed9334 into main Oct 25, 2024
5 checks passed
@jackofallops jackofallops deleted the b/broader-tcp-dial-failure-handling branch October 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackofallops @stephybun