Update Go-Getter test workflow to run on pull requests #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
force-pushed
the
nywilken/run-tests-on-prs
branch
from
3594d1d
to
f416c18
Compare
lbajolet-hashicorp
approved these changes
Feb 14, 2023
| push: | ||
| branches: | ||
| - v2 | ||
| pull_request: |
There was a problem hiding this comment.
Out of curiosity what does this empty section imply?
There was a problem hiding this comment.
I presume it means that it runs on all PRs pushing to v2?
There was a problem hiding this comment.
Ah good call out. This will actually run for all pull requests. I can update for any pull_requests against v2
nywilken
force-pushed
the
nywilken/run-tests-on-prs
branch
from
f416c18
to
d0faac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently test for v2 run for authors who have push access to the go-getter repo. This change updates the test action to run for all open pull-request to the v2 branch, as well as on pushes to the v2 branch.