Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't change GIT_SSH_COMMAND when there is no sshKeyFile #459

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Oct 9, 2023

The reason for setupGitEnv is to add a -i keyfile argument to GIT_SSH_COMMAND.
If there is no key file, we do not need to modify the environment at all.

The problem with #300 was that it always reset GIT_SSH_COMMAND even when there was no keyfile to add, and lost the original command string.

The reason for setupGitEnv is to add a `-i keyfile` argument to
GIT_SSH_COMMAND. If there is no keyfile, we do not need to modify the
environment at all.
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a plausible fix to me!

@jbardin jbardin merged commit 0298a22 into main Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants