Sets request's GetBody field on create wrapper #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two key issues: - Upon receiving a temporary redirect, net/http will only preserve the request's body if GetBody() is defined. - Upon receiving a GOAWAY frame, the client will create a new connection. We define GetBody() in order to reuse the body sent in the last stream on the now terminated connection.
sebasslash
force-pushed
the
sebasslash/handle-go-away
branch
from
528a6ca
to
f95735f
Compare
dekimsey
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
I was wondering if we needed to test for 307/308 response codes before setting the GetBody, but it looks like Client.Do is pretty clear that it'll only invoke this helper if it thinks it should. So that works for me!
I 💯 appreciate the additional tests! Thank you
brandonc
reviewed
Nov 8, 2023
|
|
||
| func TestClient_RedirectWithBody(t *testing.T) { | ||
| var redirects int32 | ||
| // Mock server which always responds 200. |
| w.Header().Set("Location", "/target") | ||
| w.WriteHeader(http.StatusTemporaryRedirect) | ||
| case "/target": | ||
| atomic.AddInt32(&redirects, 1) |
There was a problem hiding this comment.
Should this test that the body was received?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
This commit addresses two key issues:
Not entirely sure why the fix was never merged, but here we are :) Credits to @rgb-24bit