Skip processing deleted directories during sourcebundle.Build #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when building the source bundle, if an excluded directory had files in it, the build process would error because filepath.Walk computes the list of children for a directory before executing the walk function on that directory. Our function was deleting the directory (and all children) and then returning an error later when it tried to process (the now deleted) children.
Now, when we delete the directory we return the filepath.SkipDir directory which tells it to stop trying to recurse and it won't process the deleted children.