Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provisional for ConfigurationVersions; Add current-configuration-version to Workspaces #746

Conversation

brandonc
Copy link
Collaborator

Description

  • Adds BETA field Provisional (does not set configuration version as workspace current)
  • Adds CurrentConfigurationVersion relation to Workspace

Testing plan

See automated test output

$ ENABLE_BETA=1 go test ./... -run TestConfigurationVersionsCreate -v
?   	github.com/hashicorp/go-tfe/examples/configuration_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/registry_modules	[no test files]
?   	github.com/hashicorp/go-tfe/examples/organizations	[no test files]
?   	github.com/hashicorp/go-tfe/examples/state_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/users	[no test files]
?   	github.com/hashicorp/go-tfe/examples/workspaces	[no test files]
?   	github.com/hashicorp/go-tfe/mocks	[no test files]
=== RUN   TestConfigurationVersionsCreate
=== RUN   TestConfigurationVersionsCreate/with_valid_options
=== RUN   TestConfigurationVersionsCreate/with_invalid_workspace_id
=== RUN   TestConfigurationVersionsCreate/provisional
--- PASS: TestConfigurationVersionsCreate (16.65s)
    --- PASS: TestConfigurationVersionsCreate/with_valid_options (3.39s)
    --- PASS: TestConfigurationVersionsCreate/with_invalid_workspace_id (0.00s)
    --- PASS: TestConfigurationVersionsCreate/provisional (3.26s)
PASS
ok  	github.com/hashicorp/go-tfe	16.952s
...

@laurenolivia
Copy link
Contributor

I added the DO NOT MERGE label so the hero after me does not merge this one bc the atlas PR hasn't merged. @brandonc

Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM!

  • todo: Update changelog to reflect the provisional attribute

@brandonc brandonc force-pushed the TF-7651-go-tfe-add-provisional-attribute-for-configuration-versions branch from 16dbf5b to c456f6f Compare August 3, 2023 15:31
@brandonc
Copy link
Collaborator Author

brandonc commented Aug 4, 2023

Merging without approval because the platform change is deployed and I updated the CHANGELOG

@brandonc brandonc merged commit 6f876e4 into main Aug 4, 2023
9 checks passed
@brandonc brandonc deleted the TF-7651-go-tfe-add-provisional-attribute-for-configuration-versions branch August 4, 2023 19:13
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants