Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks: Decode diagnostics #956

Merged

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Aug 8, 2024

Description

Decode diagnostics for stack_configuration and stack_plan_operation

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

@DanielMSchmidt DanielMSchmidt force-pushed the decode-stack-diagnostics-trying-brandonc-suggestion branch from def4a56 to 0c1f98e Compare August 8, 2024 15:43
@DanielMSchmidt DanielMSchmidt changed the title decode stack diagnostics trying brandonc suggestion Stacks: Decode diagnostics Aug 9, 2024
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have some tests (marked SkipUnlessBeta) for diagnostics decoding but I also recognize there are a lot of tests we need to backfill as we get more setup automation in place

@DanielMSchmidt DanielMSchmidt merged commit b585e79 into main Aug 12, 2024
7 checks passed
@DanielMSchmidt DanielMSchmidt deleted the decode-stack-diagnostics-trying-brandonc-suggestion branch August 12, 2024 12:38
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants