Merge pull request #245 from octo/cartridge-return

scanner: Improve regular expression in "scanner".scanHeredoc().
hashicorp · Apr 3, 2018 · c247bd0 · c247bd0
2 parents f40e974 + 25340db
commit c247bd0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/hcl/printer/printer_test.go b/hcl/printer/printer_test.go
@@ -153,6 +153,8 @@ func TestFormatValidOutput(t *testing.T) {
 	cases := []string{
 		"#\x00",
 		"#\ue123t",
+		"Y=<<4\n4/\n\n\n/4/@=4/\n\n\n/4000000004\r\r\n00004\n",
+		"x=<<_\n_\r\r\n_\n",
 	}
 
 	for _, c := range cases {

diff --git a/hcl/printer/testdata/object_with_heredoc.golden b/hcl/printer/testdata/object_with_heredoc.golden
@@ -1,6 +1,7 @@
 obj {
   foo = [<<EOF
         TEXT!
+!!EOF
 EOF
   ]
 }
diff --git a/hcl/printer/testdata/object_with_heredoc.input b/hcl/printer/testdata/object_with_heredoc.input
@@ -1,6 +1,7 @@
 obj {
     foo = [<<EOF
         TEXT!
+!!EOF
 EOF
     ]
 }
diff --git a/hcl/scanner/scanner.go b/hcl/scanner/scanner.go
@@ -440,9 +440,9 @@ func (s *Scanner) scanHeredoc() {
 
 	var identRegexp *regexp.Regexp
 	if identBytes[0] == '-' {
-		identRegexp = regexp.MustCompile(fmt.Sprintf(`[[:space:]]*%s\z`, identBytes[1:]))
+		identRegexp = regexp.MustCompile(fmt.Sprintf(`^[[:space:]]*%s\r*\z`, identBytes[1:]))
 	} else {
-		identRegexp = regexp.MustCompile(fmt.Sprintf(`[[:space:]]*%s\z`, identBytes))
+		identRegexp = regexp.MustCompile(fmt.Sprintf(`^[[:space:]]*%s\r*\z`, identBytes))
 	}
 
 	// Read the actual string value