Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockMarshaler and ExpressionMarshaler interfaces #608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ropnop
Copy link

@ropnop ropnop commented May 10, 2023

Hello! This addresses my feature request in #607 . Internally we have a need for this as we want to be able to implement custom types that either emit raw, unescaped HCL, and be able to encode map[string]string to HCL easily.

These 2 interfaces let us implement the custom marshalling logic in our code while introducing minimal changes to this library code.

I added a few tests in encode_test.go to demonstrate using these interfaces to overwrite expression and block marshaling behavior on custom types, as well as some tests for handling pointer, nil and zero cases (nil and zero will panic - i think this desired behavior)

Let me know what you think - thanks!

@hashicorp-cla
Copy link

hashicorp-cla commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@yuri-tceretian
Copy link

Great feature! That can make encoding to HCL really powerful and let us implement custom encoding the same way we do JSON\YAML marshallers.

It would be great if maintainers could take a look and eventually merge it.

@mickeypash
Copy link

@ansgarm what are the steps to getting this merged?

@crw
Copy link
Contributor

crw commented Oct 1, 2024

Hi, we discussed this in triage today. This looks like a feature that we would be willing to review. The main barrier is the time it would take to understand why it was not implemented this way originally, to make sure we were not inadvertently introducing new issues by committing this change. Unfortunately, this comes down to maintainer availability. Hopefully the next time someone is doing a deep dive into HCL, we can pick this back up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants