Skip to content
This repository has been archived by the owner on Oct 3, 2019. It is now read-only.

hclwrite: Fix improper indent calculation inside heredocs #107

Merged
merged 1 commit into from
Jul 22, 2019
Merged

hclwrite: Fix improper indent calculation inside heredocs #107

merged 1 commit into from
Jul 22, 2019

Conversation

nozaq
Copy link
Contributor

@nozaq nozaq commented May 26, 2019

Potential fix for #106.

linesForFormat function already put all tokens in one heredoc into one formatLine instance, so formatIndent function does not need to go through multiple lines to find the corresponding TokenCHeredoc. Instead, it can just ignore the whole line.

@hashicorp-cla
Copy link

hashicorp-cla commented May 26, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #107 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   68.69%   68.72%   +0.03%     
==========================================
  Files          98       98              
  Lines       10299    10293       -6     
==========================================
- Hits         7075     7074       -1     
+ Misses       2897     2894       -3     
+ Partials      327      325       -2
Impacted Files Coverage Δ
hclwrite/format.go 95.59% <100%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b22149...25cac01. Read the comment docs.

@pselle pselle merged commit 984d1e8 into hashicorp:master Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants