Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the namespace in job_status_checker #356

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Pass the namespace in job_status_checker #356

merged 1 commit into from
Oct 22, 2020

Conversation

fuleow
Copy link
Contributor

@fuleow fuleow commented Aug 27, 2020 •
edited
Loading

Pass the namespace to the query options when querying for the job status. Resolves #333

@jrasell jrasell self-requested a review August 28, 2020 09:53
@jrasell jrasell self-assigned this Aug 28, 2020
@chuckyz
Copy link

chuckyz commented Oct 19, 2020

@jrasell can we get this merged now that 1.0 is putting namespace into OSS?

@robloxrob
Copy link

Plzz

@jrasell
Copy link
Member

jrasell commented Oct 22, 2020

@fuleow thanks a lot for this; LGTM!

@jrasell jrasell merged commit 72ae90b into hashicorp:master Oct 22, 2020
@alexdulin alexdulin mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

levant/job_status_checker ignores job's namespace
4 participants
@fuleow @chuckyz @robloxrob @jrasell