Prevent a couple panics on malformed input #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numParts was being cast to an int incorrectly, which could lead to numParts overflowing and reporting 0 after being multiplied by 2. This would lead to a panic because the check for buffer length would not properly detect that the buffer was smaller than the number of parts.
When handleCommand is called by handleCompressed it could be called with an empty buffer. Handle the empty buffer by logging and error and returning.
picatz
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two possible panics that could be caused by malformed input of compound messages or compressed messages.
The two tests that were added both panicked without these code changes.