Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul will support envoy 1.15.0 with Consul 1.9 #8585

Closed
rboyer opened this issue Jul 31, 2020 · 2 comments
Closed

Consul will support envoy 1.15.0 with Consul 1.9 #8585

rboyer opened this issue Jul 31, 2020 · 2 comments
Assignees
@shoenig
Labels
theme/consul/connect Consul Connect integration theme/dependencies Pull requests that update a dependency file type/enhancement

Comments

@rboyer
Copy link
Member

rboyer commented Jul 31, 2020

See hashicorp/consul#8424

As discussed elsewhere, we'll also add a TBD API endpoint that nomad can use to get the supported envoy version range for a given agent that will likely make this easier going forward.
@rboyer rboyer added the theme/consul/connect Consul Connect integration label Jul 31, 2020
@rboyer rboyer mentioned this issue Jul 31, 2020
Merged
14 tasks
@shoenig shoenig mentioned this issue Aug 10, 2020
Closed
@tgross tgross added type/enhancement theme/dependencies Pull requests that update a dependency file labels Aug 24, 2020
shoenig added a commit that referenced this issue Sep 16, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
8f899ed 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the API component is not available, Nomad will fallback to
the old version of Envoy supported by old versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior.

Addresses #8585 #7665
shoenig added a commit that referenced this issue Sep 22, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
cc34fff 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses #8585 #7665
@shoenig shoenig mentioned this issue Sep 22, 2020
Merged
shoenig added a commit that referenced this issue Oct 13, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
bdeb73c 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses #8585 #7665
@shoenig shoenig self-assigned this Oct 13, 2020
@shoenig
Copy link
Member

shoenig commented Oct 13, 2020

Should be addressed by #8945, however we'll want to make sure https://github.com/orgs/hashicorp/projects/62#card-45960173 is not still a problem before release.

fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this issue Oct 22, 2020
@shoenig @fredrikhgrelland
consul/connect: dynamically select envoy sidecar at runtime
5b51397 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses hashicorp#8585 hashicorp#7665
@shoenig shoenig closed this as completed Dec 2, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
theme/consul/connect Consul Connect integration theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rboyer @shoenig @tgross