Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] General keyboard navigation in the UI #12831

Closed
wants to merge 35 commits into from
Closed

[ui] General keyboard navigation in the UI #12831

wants to merge 35 commits into from

Commits on Aug 3, 2022

  1. Initialized keyboard service

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    5e4d53e View commit details
    Browse the repository at this point in the history

  2. Neat but funky: dynamic subnav traversal

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    8572f93 View commit details
    Browse the repository at this point in the history

  3. 👻

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    4dfe021 View commit details
    Browse the repository at this point in the history

  4. generalized traverseSubnav method

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    b6faeb3 View commit details
    Browse the repository at this point in the history

  5. Shift as special modifier key

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    0905d16 View commit details
    Browse the repository at this point in the history

  6. Nice little demo panel

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    f001cc0 View commit details
    Browse the repository at this point in the history

  7. Keyboard shortcuts keycard

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    3d4c637 View commit details
    Browse the repository at this point in the history

  8. Some animation styles on keyboard shortcuts

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    a3c495f View commit details
    Browse the repository at this point in the history

  9. Handle situations where a link is deeply nested from its parent menu … 

    …item
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    3fd3d40 View commit details
    Browse the repository at this point in the history

  10. Keyboard service cleanup

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    d3121cf View commit details
    Browse the repository at this point in the history

  11. helper-based initializer and teardown for new contextual commands

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    3ade9b5 View commit details
    Browse the repository at this point in the history

  12. Keyboard shortcuts modal component added and demo-ghost removed

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    84a2f33 View commit details
    Browse the repository at this point in the history

  13. Removed j and k from subnav traversal

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    30957db View commit details
    Browse the repository at this point in the history

  14. Register and unregister methods for subnav plus new subnavs for volum… 

    …es and volume
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c0c45ce View commit details
    Browse the repository at this point in the history

  15. register main nav method

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    2ba2e70 View commit details
    Browse the repository at this point in the history

  16. Generalizing the register nav method

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    65b2307 View commit details
    Browse the repository at this point in the history

  17. 12762 table keynav (#12975) 

    * Experimental feature: shortcut visual hints

* Long way around to a custom modifier for keyboard shortcuts

* dynamic table and list iterative shortcuts

* Progress with regular old tether

* Delogging

* Table Keynav tether fix, server and client navs, and fix to shiftless on modified arrow keys
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    7d034cb View commit details
    Browse the repository at this point in the history

  18. Go to Optimize keyboard link and storage key changed to g r

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    0a51649 View commit details
    Browse the repository at this point in the history

  19. parameterized jobs keyboard nav

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c6191d4 View commit details
    Browse the repository at this point in the history

  20. Dynamic numeric keynav for multiple tables (#13482) 

    * Multiple tables init

* URL-bind enumerable keyboard commands and add to more taskRow and allocationRows

* Type safety and lint fixes

* Consolidated push to keyCommands

* Default value when removing keyCommands

* Remove the URL-based removal method and perform a recompute on any add
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    0444b74 View commit details
    Browse the repository at this point in the history

  21. Variables keyboard nav added

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    68e5999 View commit details
    Browse the repository at this point in the history

  22. Variable traversal functionality added to shortcuts

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    357b3d7 View commit details
    Browse the repository at this point in the history

  23. Get tests passing in Keynav: remove math helpers and a few other defe… 

    …nsive moves (#13761)

* Remove ember math helpers

* Test fixes for jobparts/body

* Kill an unneeded integration helper test

* delog

* Trying if disabling percy lets this finish

* Okay so its not percy; try parallelism in circle

* Percyless yet again

* Trying a different angle to not have percy

* Upgrade percy to 1.6.1
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    9fb422e View commit details
    Browse the repository at this point in the history

  24. [ui] Keyboard nav: "u" key to go up a level (#13754) 

    * U to go up a level

* Mislabelled my conditional

* Custom lint ignore rule

* Custom lint ignore rule, this time with commas

* Since we're getting rid of ember math helpers elsewhere, do the math ourselves here
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    2579036 View commit details
    Browse the repository at this point in the history

  25. Replace ArrowLeft etc. with an ascii arrow (#13776) 

    * Replace ArrowLeft etc. with an ascii arrow

* non-mutative helper cleanup
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    3983019 View commit details
    Browse the repository at this point in the history

  26. Keyboard Nav: let users rebind their shortcuts (#13781) 

    * click-outside and shortcuts enabled/disabled toggle

* Trap focus when modal open

* Enabled/disabled saved to localStorage

* Autofocus edit button on variable index

* Modal overflow styles

* Functional rebind

* Saving rebinds to localStorage for all majors

* Started on defaultCommandBindings

* Modal header style and cancel rebind on escape

* keyboardable keybindings w buttons instead of spans

* recording and defaultvalues

* Enter short-circuits rebind

* Only some commands are rebindable, and dont show dupes

* No unused get import

* More visually distinct header on modal

* Disallowed keys for rebind, showing buffer as you type, and moving dedupe to modal logic
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    354a149 View commit details
    Browse the repository at this point in the history

  27. willDestroy hook to prevent tests from doubling/tripling up addEventL… 

    …istener on kb events
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    711b56c View commit details
    Browse the repository at this point in the history

  28. remove unused tests

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    964637a View commit details
    Browse the repository at this point in the history

  29. Keyboard Navigation acceptance tests (#13893) 

    * Acceptance tests for keyboard modal

* a11y audit fix and localStorage clear

* Bind/rebind/localStorage tests

* Keyboard tests for dynamic nav and tables

* Rebinder and assert expectation

* Second percy snapshot showing hints no longer relevant
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    2ee33d0 View commit details
    Browse the repository at this point in the history

  30. Weird issue where linktos with query props specifically from the task… 

    …-groups page would fail to route / hit undefined.shouldSuperCede errors
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    6b6ba94 View commit details
    Browse the repository at this point in the history

  31. Adds the concept of exclusivity to a keycommand, removing peers that … 

    …also share its label
    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e3d6a26 View commit details
    Browse the repository at this point in the history

  32. Lintfix

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    cd45721 View commit details
    Browse the repository at this point in the history

  33. Changelog and PR feedback

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    7284497 View commit details
    Browse the repository at this point in the history

  34. Changelog and PR feedback

    @philrenaud
    philrenaud committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c23b7a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Fix to rebinding in firefox by blurring the now-disabled button on re… 

    …bind (#14053)
    @philrenaud
    philrenaud authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    36cc240 View commit details
    Browse the repository at this point in the history