Variables-specific keyboard commands #14165
Conversation
| <td colspan="3" | ||
| {{keyboard-shortcut | ||
| enumerated=true | ||
| action=(fn this.handleFolderClick folder.data.absolutePath) |
There was a problem hiding this comment.
blocking: This should accept a namespace.
There was a problem hiding this comment.
clicking into a folder doesn't do any variable read, only variable list (like clicking into a folder in a file directory). As such, if the folder is present at all it means the user has access to list at least one variable within it and it should remain clickable. Thus, no namespace passing.
In addition: the concept of "folders" are generated in the ui and do not themselves even have namespaces. They can contain many variables from many different namespaces. So nothing to pass in even if it was a good idea to do so.
| @@ -29,6 +34,10 @@ | |||
| data-test-file-row | |||
| {{on "click" (fn this.handleFileClick file)}} | |||
| class={{if (can "read variable" path=file.absoluteFilePath namespace=file.variable.namespace) "" "inaccessible"}} | |||
| {{keyboard-shortcut | |||
| enumerated=true | |||
| action=(fn this.handleFileClick file) | |||
There was a problem hiding this comment.
blocking: This should accept a namespace.
There was a problem hiding this comment.
Hi @ChaiWithJai — the handleFileClick action reads namespace from the variable (passed here as file) itself. As such , namespaces do not need to be passed in. This is the same logic we use a couple lines above this in the on "click".
Ember Asset Size actionAs of d37540d Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adds variables-specific keyboard nav:
g vto go to variables, globallyvto show/hide values on a variable pagejto switch to/from JSON mode when viewing or editing a variableShift + NUMto enter a folder/file( Port of 68e5999 and 357b3d7 )