CI: Dynamic runs-on values for oss/ent #17775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulducat
added
backport/1.4.x
tgross
approved these changes
Jun 30, 2023
|
Heya @philrenaud and/or @DingoEatingFuzz since ya touched the test-ui pipeline recently -- let me know if you have any concerns about 3ea6809 ? self-hosted runners are different enough from github-hosted that test-ui needed some extra finagling. edit: and mind reviewing Percy for me @philrenaud ? "5 visual changes need review" |
philrenaud
approved these changes
Jul 5, 2023
so in enterprise we can use Vault for secrets, without merge conflicts from oss->ent. also: * use hashicorp/setup-golang * setup-js for self-hosted runners they don't come with yarn, nor chrome, and might not always match node version.
This was referenced Jul 6, 2023
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fetch secrets from Vault in our Enterprise repo, we need to use self-hosted runners, but here in this public repo, we may only use public runners.
To reduce merge conflicts between OSS and ENT (and backports..), this PR adds conditions that will result in public runners here in OSS, but self-hosted runners in ENT. I have done a lot of trial-and-error to end up with what I hope is a nice middle-ground between complexity, explicitness, and non-mergeflictery.
A subsequent PR will add the steps to (again, conditionally) fetch secrets from Vault.