Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Makefile: replace enumer upstream with dmarkham's into release/1.11.x #13108

Conversation

hc-github-team-packer
Copy link
Collaborator

Backport

This PR is auto-generated from #13107 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

The below text is copied from the body of the original PR.


Since the enumer implementation we used hadn't been updated for 5+ years, this didn't work with recent linux/go versions, and enumer crashed while attempting to parse/analyse the source files.

There's another alternative on Github, forked from the one we used, which seems more maintained now, and does produce the expected files in Packer.

Closes: #13082


Overview of commits

@hc-github-team-packer hc-github-team-packer requested a review from a team as a code owner July 17, 2024 01:14
@hc-github-team-packer hc-github-team-packer force-pushed the backport/replace_enumer_upstream/blindly-sacred-rat branch from 340fc41 to 496f51b Compare July 17, 2024 01:14
@hc-github-team-packer hc-github-team-packer merged commit 0f15855 into release/1.11.x Jul 17, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants