datasource: fix test for invalid method #13199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the expected error to look for in the output is compiled to a regexp, the `[]` from the error message were interpreted as a set of characters, which made the regexp not match the expected output from the command. So to avoid this problem, we escape them so they are expected verbatim in the command output.
The acceptance tests for the HTTP datasource had a `Outputs` attribute for checking the output of the command for a specific regexp pattern. As pointed out, given the expectative nature of the attribute, naming it `Outputs` did not make the intent clear, so we rename it to `ExpectedOutputs` with this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the expected error to look for in the output is compiled to a regexp, the
[]from the error message were interpreted as a set of characters, which made the regexp not match the expected output from the command.So to avoid this problem, we escape them so they are expected verbatim in the command output.