-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu builder and vbox builders now need to explicitly set WinRMPort for StepConnect #4321
Conversation
This probably effects |
@rickard-von-essen I think you're right there! Perhaps
from lines 394 - 403 of builder/qemu/builder.go should be changed in a similar way. e.g.
@rickard-von-essen @vtolstov Unfortunately, I don't have the setup to be able to test the qemu builder. However, if the qemu builder was broken by #2576 and that change actually fixes it, I would be happy to submit the change above in with this PR... |
Please, wait i'm recheck qemu builder now |
Yes, under qemu winrm is broken in current master.
But packer use default port
|
@DanHam please add fix for qemu builder |
Same as vbox builders, aligns qemu with changes to helper/communicator/step_connect.go introduced by PR #2576
@vtolstov Done. Hopefully that will fix. Please test again. |
Thanks, i'm trying. |
i'm check windows build and not it works fine, so lgtm |
OK. Good news. Thanks for providing the testing! |
Great work! 🎄 |
@rickard-von-essen Thanks! Have a very Merry Christmas!! |
How about a small bugfix release 0.12.2 which fixes this problem for VirtualBox? |
#2576 introduced a bug that broke WinRM for Virtualbox builders since it made changes to the way
WinRMPort
was defined in helper/communicator/step_connect.go - see #4310. Hopefully this change aligns the Virtualbox builders to the new way of doing things.I've tested the changes with the Virtualbox iso builder and communication over WinRM is now working again. I've also tested a Linux build to ensure the ssh communicator is still working as expected.
Note that the Virtualbox ovf builder should also be affected by the changes #2576 made. I haven't been able to perform any checks that this is actually the case as I don't have an ovf template to hand...
Closes #4310