Instance Running waiter not aware of global waiter settings #8699
Conversation
|
|
| InstanceIds: []*string{&instanceId}, | ||
| } | ||
|
|
||
| err := conn.WaitUntilInstanceRunningWithContext( |
There was a problem hiding this comment.
Oh super nice, I wasn't aware of this one !
There was a problem hiding this comment.
Nice! Seeing as we don’t actually use err here we can just return with the call to conn.WaitUntilInstanceRunningWithContext(...
There was a problem hiding this comment.
@nywilken I'm following the convention of other existing WaitUntil* methods in state.go
There was a problem hiding this comment.
@fly1028 thanks I only looked at the diff. But this is good to go I just have not had a chance to merge.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This is related to #6177.
The work done for #6177 didn't really address the hardcoded timeout issue for the run source instance step.
Specifically, it's not aware of the AWS_POLL_DELAY_SECONDS and AWS_TIMEOUT_SECONDS.