Fix key vault creation in Azure allowing the terraform run to upload certs #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THis allows the service principal to add the SSL certificates to the keyvault.
Add the Service Principal Application id to the access policy.
pull changes in from upstream
This reverts commit de64d2b.
PR for branch prior to closure
erindatkinson
approved these changes
Dec 11, 2019
|
You're welcome @bnferguson. |
|
I am very glad that my small contribution helped in some way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #22.
Ran into the same problem @ausfestivus did with the key vault setup in the bootstrap.
Luckily they wrote up their issues over in hashicorp/terraform-azurerm-terraform-enterprise#47 and in turn https://github.com/ausfestivus/tfe-demo/blob/master/azureKeyvaultTroubleshooting.md. The latter leading me to this branch, which solved my issues.
Of particular interest is the user creation being done in a way that it can be done in a single pass instead of requiring two
planandapplypasses (mine was still broken after that even but this these changes patched it up) described in this issue: hashicorp/terraform-provider-azurerm#1569 (comment)Hopefully @ausfestivus doesn't mind me opening a PR for their branch. :D (and thank you for such a great set of write ups!)