Skip to content

Commit

Permalink
add more excluded env vars
Browse files Browse the repository at this point in the history
  • Loading branch information
kmoe committed Sep 9, 2020
1 parent 4052798 commit a04c890
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 13 deletions.
20 changes: 12 additions & 8 deletions tfexec/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ import (
)

const (
checkpointDisableEnvVar = "CHECKPOINT_DISABLE"
logEnvVar = "TF_LOG"
inputEnvVar = "TF_INPUT"
automationEnvVar = "TF_IN_AUTOMATION"
logPathEnvVar = "TF_LOG_PATH"
reattachEnvVar = "TF_REATTACH_PROVIDERS"
appendUserAgentEnvVar = "TF_APPEND_USER_AGENT"
workspaceEnvVar = "TF_WORKSPACE"
checkpointDisableEnvVar = "CHECKPOINT_DISABLE"
logEnvVar = "TF_LOG"
inputEnvVar = "TF_INPUT"
automationEnvVar = "TF_IN_AUTOMATION"
logPathEnvVar = "TF_LOG_PATH"
reattachEnvVar = "TF_REATTACH_PROVIDERS"
appendUserAgentEnvVar = "TF_APPEND_USER_AGENT"
workspaceEnvVar = "TF_WORKSPACE"
disablePluginTLSEnvVar = "TF_DISABLE_PLUGIN_TLS"
skipProviderVerifyEnvVar = "TF_SKIP_PROVIDER_VERIFY"

varEnvVarPrefix = "TF_VAR_"
)
Expand All @@ -35,6 +37,8 @@ var prohibitedEnvVars = []string{
reattachEnvVar,
appendUserAgentEnvVar,
workspaceEnvVar,
disablePluginTLSEnvVar,
skipProviderVerifyEnvVar,
}

func envMap(environ []string) map[string]string {
Expand Down
34 changes: 29 additions & 5 deletions tfexec/terraform.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package tfexec

import (
"context"
"fmt"
"io"
"io/ioutil"
Expand Down Expand Up @@ -32,11 +33,15 @@ type printfer interface {
// - TF_LOG
// - TF_LOG_PATH
// - TF_REATTACH_PROVIDERS
// - TF_DISABLE_PLUGIN_TLS
// - TF_SKIP_PROVIDER_VERIFY
type Terraform struct {
execPath string
workingDir string
appendUserAgent string
env map[string]string
execPath string
workingDir string
appendUserAgent string
disablePluginTLS bool
skipProviderVerify bool
env map[string]string

stdout io.Writer
stderr io.Writer
Expand Down Expand Up @@ -125,8 +130,27 @@ func (tf *Terraform) SetLogPath(path string) error {

// SetAppendUserAgent sets the TF_APPEND_USER_AGENT environment variable for
// Terraform CLI execution.
func (tf *Terraform) SetAppendUserAgent(ua string) {
func (tf *Terraform) SetAppendUserAgent(ua string) error {
tf.appendUserAgent = ua
return nil
}

// SetDisablePluginTLS sets the TF_DISABLE_PLUGIN_TLS environment variable for
// Terraform CLI execution.
func (tf *Terraform) SetDisablePluginTLS(disabled bool) error {
tf.disablePluginTLS = disabled
return nil
}

// SetSkipProviderVerify sets the TF_SKIP_PROVIDER_VERIFY environment variable
// for Terraform CLI execution. This is no longer used in 0.13.0 and greater.
func (tf *Terraform) SetSkipProviderVerify(skip bool) error {
err := tf.compatible(context.Background(), nil, tf0_13_0)
if err != nil {
return err
}
tf.skipProviderVerify = skip
return nil
}

// WorkingDir returns the working directory for Terraform.
Expand Down
1 change: 1 addition & 0 deletions tfexec/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

var (
tf0_12_0 = version.Must(version.NewVersion("0.12.0"))
tf0_13_0 = version.Must(version.NewVersion("0.13.0"))
)

// Version returns structured output from the terraform version command including both the Terraform CLI version
Expand Down

0 comments on commit a04c890

Please sign in to comment.