Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Update the script for google provider 2.0.0 #58

Closed
wants to merge 2 commits into from
Closed

Update the script for google provider 2.0.0 #58

wants to merge 2 commits into from

Conversation

anonyknight
Copy link

Using the latest google provider 3.54.0 will have the following errors:

Error: Unsupported argument

on .terraform/modules/vault_cluster/modules/vault-cluster/main.tf line 60, in resource "google_compute_region_instance_group_manager" "vault":
60: instance_template = data.template_file.compute_instance_template_self_link.rendered

An argument named "instance_template" is not expected here.

Error: Unsupported argument

on .terraform/modules/vault_cluster/modules/vault-cluster/main.tf line 66, in resource "google_compute_region_instance_group_manager" "vault":
66: update_strategy = var.instance_group_update_strategy

An argument named "update_strategy" is not expected here.

update_strategy was documented in
https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_2_upgrade

update_strategy was obsolete.
instance_template argument was updated.
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@robmorgan
Copy link
Collaborator

@anonyknight thanks for your contribution! This PR includes some of the same functionality we are hoping to introduce in #55, however the problem we are facing is that for some reason Vault is unable to discover other nodes in the cluster likely due to a Consul DNS issue. As #55 includes a lot more additional functionality I'll close this PR, however feel free to test #55, see if it works for you and optionally submit any necessary fixes. Thanks!

@robmorgan robmorgan closed this Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants