Adjust NestedAttributesEqual to perform shallow compare first (#762)

hashicorp · Jun 13, 2023 · 1d1bf84 · 1d1bf84
1 parent 8cfc161
commit 1d1bf84
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/fwschema/nested_attribute.go b/internal/fwschema/nested_attribute.go
@@ -22,13 +22,13 @@ type NestedAttribute interface {
 // NestedAttribute. NestedAttribute Equal implementations should still compare
 // the concrete types in addition to using this helper.
 func NestedAttributesEqual(a, b NestedAttribute) bool {
-	if a.GetNestingMode() != b.GetNestingMode() {
+	if !AttributesEqual(a, b) {
 		return false
 	}
 
-	if !a.GetNestedObject().Equal(b.GetNestedObject()) {
+	if a.GetNestingMode() != b.GetNestingMode() {
 		return false
 	}
 
-	return AttributesEqual(a, b)
+	return a.GetNestedObject().Equal(b.GetNestedObject())
 }