-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement State, State.Get, State.GetAttribute, Config, Plan #46
Conversation
It turns out that nested attributes did not need the Please take a look at the tests to see if this provides the appropriate UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback on this one. I think the only part that's super important is the object using the wrong attribute path step type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it. 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The changes to
internal/reflect
onmain
made rather a mess ofkatystate3
. We're up tokatystate5
now.The main work here is the addition of
ApplyTerraform5AttributePathStep
to all schema types, implementing thetftypes.AttributePathStepper
interface so that we can traverse the schema withtftypes.WalkAttributePath
.