tftypes: Return null Number when NewValue receives (*big.Float)(nil) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: hashicorp/terraform-plugin-framework#89 This matches the consistency of other pointer types in the `valueFromNumber` function and can prevent unexpected panics.
paddycarver
approved these changes
Oct 5, 2021
bflad
added a commit
that referenced
this pull request
Oct 5, 2021
bflad
added a commit
to hashicorp/terraform-plugin-framework
that referenced
this pull request
Oct 5, 2021
Reference: #89 Reference: hashicorp/terraform-plugin-go#114 This change will ensure that if the `Number` `Value` pointer is `nil`, that the returned value is an untyped `nil`, rather than a `*big.Float` typed `nil`. The upstream `(tftypes.Value).IsNull()` method can only detect untyped `nil` for values. A related fix for `tftypes.NewValue()` to convert a `*big.Float` `nil` value into an untyped `nil` has also been merged upstream to fix this in depth. Previously, this new test case would pass: ```go "value-nil": { input: Number{Value: nil}, expectation: (*big.Float)(nil), }, ``` Now it appropriately expects: ```go "value-nil": { input: Number{Value: nil}, expectation: nil, }, ```
bflad
added a commit
to hashicorp/terraform-plugin-framework
that referenced
this pull request
Oct 5, 2021
Reference: #89 Reference: hashicorp/terraform-plugin-go#114 This change will ensure that if the `Number` `Value` pointer is `nil`, that the returned value is an untyped `nil`, rather than a `*big.Float` typed `nil`. The upstream `(tftypes.Value).IsNull()` method can only detect untyped `nil` for values. A related fix for `tftypes.NewValue()` to convert a `*big.Float` `nil` value into an untyped `nil` has also been merged upstream to fix this in depth. Previously, this new test case would pass: ```go "value-nil": { input: Number{Value: nil}, expectation: (*big.Float)(nil), }, ``` Now it appropriately expects: ```go "value-nil": { input: Number{Value: nil}, expectation: nil, }, ```
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: hashicorp/terraform-plugin-framework#89
This matches the consistency of other pointer types in the
valueFromNumberfunction and can prevent unexpected panics.