Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate provider name into GRPCProviderPlugin #150

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

alexsomesan
Copy link
Member

This resolves the bellow error message printed on provider startup:

2022/02/02 01:07:48 [ERROR] Error parsing provider name "": Invalid provider source string: The "source" attribute must be in the format "[hostname/][namespace/]name"

@bflad bflad added the bug Something isn't working label Feb 2, 2022
@bflad bflad added this to the v0.8.0 milestone Feb 2, 2022
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch, @alexsomesan! Thank you for fixing this. It looks like we don't have this issue in tf6server, so 🎉 there.

Could you also include a changelog entry? Something like the below in .changelog/150.txt would be great.

```release-note:bug
tfprotov5/tf5server: Prevent empty provider address error logs on startup
```

Thanks again!

@bflad
Copy link
Contributor

bflad commented Feb 4, 2022

I discovered through testing hashicorp/terraform-plugin-sdk#857, we also need to pass Opts: opts through there as well, otherwise acceptance testing logging does not constrain the protocol logging by default. I'm going to pull this in (with the changelog entry) and separately work on that issue, hopefully with some unit testing.

@bflad bflad merged commit ea77932 into hashicorp:main Feb 4, 2022
bflad added a commit that referenced this pull request Feb 4, 2022
@alexsomesan alexsomesan deleted the grpc-provider-name branch February 8, 2022 15:10
@alexsomesan
Copy link
Member Author

Thanks for doing my work for me and adding the change-log entry. Got sidetracked and completely forgot about it.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants