tfprotov5+tfprotov6: Initial ephemeral resource type implementation #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ename `PriorState` request fields to `State`.
# Conflicts: # tfprotov5/internal/tfplugin5/tfplugin5.pb.go # tfprotov6/internal/tfplugin6/tfplugin6.pb.go
1 task
austinvalle
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Great work! Left some notes on the doc comments (only on protov5, but also applicable to the v6 package docs), but overall LGTM 🚀
Also created #442 for the follow-up release (probably included with write-only support I'd imagine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of the plugin protocol (5.7/6.7) introduces a new ephemeral resource type with it's own lifecycle. The ephemeral resource lifecycle introduces new RPCs for provider servers to implement including:
ValidateEphemeralResourceConfigOpenEphemeralResourceRenewEphemeralResourceCloseEphemeralResourceThis change introduces the initial implementation of that support including:
EphemeralResourceServerinterface intfprotov5andtfprotov6packages that defines the RPCs for the ephemeral resource lifecycleServerWithEphemeralResourcesinterface intfprotov5andtfprotov6for provider servers to implementEphemeralResourceServertfprotov5/tf5serverandtfprotov6/tf6serverfor the newValidateEphemeralResourceConfig,OpenEphemeralResource,RenewEphemeralResource,CloseEphemeralResourceRPCsThis change will temporarily not require
ProviderServerimplementations to implementEphemeralResourceServer, however, that requirement and the removal of theServerWithEphemeralResourcesinterface will occur in a subsequent release.