Skip to content

Commit

Permalink
r/aws_quicksight: fix window_options.bounds validator (#34230)
Browse files Browse the repository at this point in the history
The various nested bounds arguments all contained validation functions checking
for integer ranges, but were TypeFloat types. Changing the validation function
to one which expects float types should resolve static validation
failures.
  • Loading branch information
jar-b authored Nov 2, 2023
1 parent d869136 commit 2bd35d3
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
9 changes: 9 additions & 0 deletions .changelog/34230.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
```release-note:bug
resource/aws_quicksight_analysis: Fix "expected type to be integer" errors in `window_options.bounds.*` argument validatation functions
```
```release-note:bug
resource/aws_quicksight_dashboard: Fix "expected type to be integer" errors in `window_options.bounds.*` argument validatation functions
```
```release-note:bug
resource/aws_quicksight_template: Fix "expected type to be integer" errors in `window_options.bounds.*` argument validatation functions
```
8 changes: 4 additions & 4 deletions internal/service/quicksight/schema/visual_map.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,22 @@ func geospatialWindowOptionsSchema() *schema.Schema {
"east": {
Type: schema.TypeFloat,
Required: true,
ValidateFunc: validation.IntBetween(-1800, 1800),
ValidateFunc: validation.FloatBetween(-1800, 1800),
},
"north": {
Type: schema.TypeFloat,
Required: true,
ValidateFunc: validation.IntBetween(-90, 90),
ValidateFunc: validation.FloatBetween(-90, 90),
},
"south": {
Type: schema.TypeFloat,
Required: true,
ValidateFunc: validation.IntBetween(-90, 90),
ValidateFunc: validation.FloatBetween(-90, 90),
},
"west": {
Type: schema.TypeFloat,
Required: true,
ValidateFunc: validation.IntBetween(-1800, 1800),
ValidateFunc: validation.FloatBetween(-1800, 1800),
},
},
},
Expand Down

0 comments on commit 2bd35d3

Please sign in to comment.