Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow_major_version_upgrade is missing from aws_rds_cluster_instance #13874

Closed
ps2goat opened this issue Jun 22, 2020 · 5 comments
Closed

allow_major_version_upgrade is missing from aws_rds_cluster_instance #13874

ps2goat opened this issue Jun 22, 2020 · 5 comments
Assignees
@johnsonaj
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.

Comments

@ps2goat
Copy link

ps2goat commented Jun 22, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.12.26
aws providers version 2.66 (I believe, I was more watching the user)

Affected Resource(s)

  • aws_rds_cluster_instance

It seems that this is missing implementation of the AllowMajorVersionUpgrade that CloudFormation uses. There was a similar bug on the core terraform project for the aws_db_instance from 2015, but I figured this issue was pretty self-explanatory. The cluster instance is an Aurora instance, and we were trying to upgrade the major version, but it had AllowMajorVersionUpgrade: false set via CloudFormation.

We can use CloudFormation or the AWS CLI to adjust this value, but wanted to bring it to your attention that this config value was missing, even in the documentation. We did try to use the value from the regular aws_db_instance, which was allow_major_version_upgrade, but terraform output that the property was unexpected.
@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Jun 22, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 22, 2020
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2020
bflad added a commit that referenced this issue Aug 17, 2020
@bflad
resource/aws_rds_cluster: Add allow_major_version_upgrade argument
be7f4fb 
Reference: #13874

Currently needs some additional work (e.g. better waiters in RDS DB Cluster or RDS DB Cluster Instance handling) so testing can pass.

Output from acceptance testing:

```
    TestAccAWSRDSCluster_AllowMajorVersionUpgrade: resource_aws_rds_cluster_test.go:160: Step 4/4 error: terraform failed: exit status 1

        stderr:

        Error: Failed to modify RDS Cluster (tf-acc-test-340394054292885352): InvalidDBClusterStateFault: Cannot modify engine version without a healthy primary instance in DB cluster: tf-acc-test-340394054292885352
        	status code: 400, request id: 2607bd75-12b6-40b5-a47b-e601680d4091

--- FAIL: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1015.90s)
```
@bflad bflad mentioned this issue Aug 17, 2020
Merged
bflad added a commit that referenced this issue Sep 18, 2020
@bflad
resource/aws_rds_cluster: Add allow_major_version_upgrade argument
8d7bc98 
Reference: #13874

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1248.28s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1457.47s)
```
bflad added a commit that referenced this issue Sep 22, 2020
@bflad @anGie44
resource/aws_rds_cluster: Add allow_major_version_upgrade argument (#…
e4f0130 
…14709)

* resource/aws_rds_cluster: Add allow_major_version_upgrade argument

Reference: #13874

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1248.28s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1457.47s)
```

* Update website/docs/r/rds_cluster_instance.html.markdown

Co-authored-by: angie pinilla <[email protected]>

* Update website/docs/r/rds_cluster_instance.html.markdown

Co-authored-by: angie pinilla <[email protected]>
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jun 27, 2022
@simonweil
Copy link

Stale label should be removed...

@github-actions github-actions bot removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jun 27, 2022
@johnsonaj johnsonaj self-assigned this Oct 17, 2022
@johnsonaj
Copy link
Contributor

After some review, and testing, it looks like adding allow_major_version_upgrade to an aws_rds_cluster_instance has no effect on the resource itself when the instance is a part of a cluster. To upgrade the major version on a RDS cluster the allow_major_version_upgrade input should be used on the aws_rds_cluster resource itself.

@johnsonaj
Copy link
Contributor

Closing since feature to upgrade major version on clusters was merged in #14709

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnsonaj johnsonaj

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@breathingdust @simonweil @ps2goat @johnsonaj