Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kinesis_firehose_delivery_stream: documentation refers to incorrect value in description #15251

Closed
StevenKGER opened this issue Sep 21, 2020 · 4 comments · Fixed by #15306
Closed
Labels
documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@StevenKGER
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Provider: 3.7.0

Affected Resource(s)

  • documentation of aws_kinesis_firehose_delivery_stream

Incorrect value

https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/docs/r/kinesis_firehose_delivery_stream.html.markdown#L360 (link maybe does not work due to markdown rendering)

image

The marked reference in line 360 should be named key_type since it is named like it in line 359 and in the provider as well. (in server_side_encryption section)

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 21, 2020
@bflad bflad added documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 22, 2020
@daisakuhazui
Copy link
Contributor

I'd like to contribute to this, is there any concensus on the best way to handle this?

@angelabad
Copy link
Contributor

Ops, sorry @daisakuhazui I didn't see your comment :-(

@bflad bflad added this to the v3.8.0 milestone Sep 23, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants