Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on key_arn documentation #15306

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Fix typo on key_arn documentation #15306

merged 1 commit into from
Sep 23, 2020

Conversation

angelabad
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15251

Release note for CHANGELOG:

NONE

@angelabad angelabad requested a review from a team September 23, 2020 14:41
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/firehose Issues and PRs that pertain to the firehose service. labels Sep 23, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Sep 23, 2020
bflad
bflad approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, @angelabad 🚀

@bflad bflad added this to the v3.8.0 milestone Sep 23, 2020
@bflad bflad merged commit 9f084d2 into hashicorp:master Sep 23, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@angelabad angelabad deleted the d-kinesis_firehose_delivery_stream-key_type branch September 25, 2020 07:07
@angelabad angelabad restored the d-kinesis_firehose_delivery_stream-key_type branch September 25, 2020 07:08
@angelabad angelabad deleted the d-kinesis_firehose_delivery_stream-key_type branch September 25, 2020 07:08
@ghost
Copy link

ghost commented Oct 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

r/kinesis_firehose_delivery_stream: documentation refers to incorrect value in description
2 participants
@angelabad @bflad