Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_redshift_orderable_cluster #15435

Closed
bflad opened this issue Oct 1, 2020 · 3 comments · Fixed by #15438
Closed

New Data Source: aws_redshift_orderable_cluster #15435

bflad opened this issue Oct 1, 2020 · 3 comments · Fixed by #15438
Assignees
Labels
new-data-source Introduces a new data source. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Oct 1, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Similar to the recent RDS-like service data sources (e.g. aws_rds_orderable_db_instance), it would be great to introduce a data source to fetch orderable Redshift Clusters for the region. We need to update the node types from dc1 to dc2 across our test configurations, so it would be nice to centralize this type of handling. It will also allow us to ensure the availability zone being used supports the node type.

New Data Source

  • aws_redshift_orderable_cluster

Potential Terraform Configuration

data "aws_redshift_orderable_cluster" "example" {
  cluster_type         = "multi-node"
  preferred_node_types = ["dc2.large", "ds2.xlarge"]
}

resource "aws_redshift_cluster" "test" {
  # ... other configuration ...

  availability_zone = tolist(data.aws_redshift_orderable_cluster.example.availability_zones)[0].name
  node_type         = data.aws_redshift_orderable_cluster.example.node_type
}

References

@bflad bflad added new-data-source Introduces a new data source. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshift Issues and PRs that pertain to the redshift service. labels Oct 1, 2020
@bflad bflad self-assigned this Oct 1, 2020
@bflad bflad added this to the v3.10.0 milestone Oct 7, 2020
bflad added a commit that referenced this issue Oct 7, 2020
Reference: #15435

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_NodeType (13.92s)
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_ClusterVersion (14.05s)
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_PreferredNodeTypes (14.05s)
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_ClusterType (14.19s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_ClusterType (18.30s)
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_NodeType (18.32s)
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_ClusterVersion (18.42s)
--- PASS: TestAccAWSRedshiftOrderableClusterDataSource_PreferredNodeTypes (18.43s)
```
@bflad
Copy link
Contributor Author

bflad commented Oct 7, 2020

This new data source has been merged and will release with version 3.10.0 of the Terraform AWS Provider, likely tomorrow. 👍

@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant