Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Amazon S3 Object Ownership #15471

Closed
bflad opened this issue Oct 3, 2020 · 5 comments · Fixed by #15482
Closed

Support Amazon S3 Object Ownership #15471

bflad opened this issue Oct 3, 2020 · 5 comments · Fixed by #15482
Labels
new-resource Introduces a new resource. service/s3 Issues and PRs that pertain to the s3 service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Oct 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon S3 Object Ownership is a new S3 feature that enables bucket owners to automatically assume ownership of objects that are uploaded to their buckets by other AWS Accounts. This helps you to standardize ownership of new objects in your bucket, and to share and manage access to these objects at scale via resource-based policies such as a bucket policy or an access point policy. Whether your S3 bucket receives data from other AWS accounts, or stores output from AWS services like AWS CloudTrail, S3 Object Ownership simplifies the work of creating and maintaining shared data sets on Amazon S3.

One important note with this functionality: S3 Object Ownership is currently under preview according to the AWS documentation, so that should also be noted in our documentation.

New Resource

  • aws_s3_bucket_ownership_controls

Potential Terraform Configuration

resource "aws_s3_bucket_ownership_controls" "example" {
  bucket = aws_s3_bucket.example.bucket

  rule {
    object_ownership = "BucketOwnerPreferred"
  }
}

References

@bflad bflad added new-resource Introduces a new resource. service/s3 Issues and PRs that pertain to the s3 service. labels Oct 3, 2020
@shuheiktgw
Copy link
Collaborator

@bflad May I work on this issue if you haven't started it?

bflad added a commit that referenced this issue Oct 5, 2020
Reference: #15471

Output from acceptance testing:

```
--- PASS: TestAccAWSS3BucketOwnershipControls_disappears_Bucket (20.73s)
--- PASS: TestAccAWSS3BucketOwnershipControls_disappears (30.25s)
--- PASS: TestAccAWSS3BucketOwnershipControls_basic (31.85s)
--- PASS: TestAccAWSS3BucketOwnershipControls_Rule_ObjectOwnership (57.12s)
```
@cloudyparts
Copy link

This looks ready - will this be in the 3.10.0 release?

@gdavison gdavison added this to the v3.10.0 milestone Oct 8, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@stefansedich
Copy link

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

Very cool! I have been waiting FOREVER for this feature, will be updating out buckets now!

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants