-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/provider: Fix and enable wrapcheck linter #15892
Comments
I'm gonna pick this up if folks don't mind. I initially got lulled into a false sense of security by running Here's the full list of data sources and resources affected; their acceptance tests are also affected. Some ancilliary files also show hits which will probably get fixed up in the final PR in the series which will enable the linter:
|
@mattburgess before you get too far, we should work through your existing pull requests (ensuring they all still pass acceptance testing) and discuss the intended fixes here. |
Here's some of the missing Contributing Guide documentation: #16794 👍 |
Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Description
golangci-lint version 1.32.0 introduced the
wrapcheck
linter, which by its own description:This is great because this is a common review item where we prefer to return error message context about when/where an error is occurring. This linter is a little more focused than the
goerr113
linter, which is also in golangci-lint but is problematic from our perspective due to:We do this regularly as this project is not intended to be used as a library.
Example Reports
Affected Resources
TBD
Definition of Done
golangci-lint run --enable wrapcheck ./aws
are addressedwrapcheck
added to.golangci.yml
The text was updated successfully, but these errors were encountered: