Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/contributing: Initial error handling documentation #16794

Merged
merged 5 commits into from
Jan 11, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 16, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #15792

Release note for CHANGELOG:

NONE

Some initial and lift/shift documentation on how to handle errors in the Terraform AWS Provider codebase. Provides a walkthrough of the AWS Go SDK error type, Terraform Plugin SDK error types, and sections on some common error scenarios and expected handling.

There will be separate section created specifically for waiters and retry logic.

Output from acceptance testing: N/A (documentation)

@bflad bflad requested a review from a team as a code owner December 16, 2020 18:27
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 16, 2020
}
```

Future documentation will show how to properly retry the remote operation for a short period of time until it is successful to remove the error completely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the "future documentation" replace the Pull Request Submission and Lifecycle document's section on using tfresource.TimedOut() with resource.Retry()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍

bflad and others added 5 commits December 16, 2020 19:14
Some initial and lift/shift documentation on how to handle errors in the Terraform AWS Provider codebase. Provides a walkthrough of the AWS Go SDK error type, Terraform Plugin SDK error types, and sections on some common error scenarios and expected handling.
@bflad
Copy link
Contributor Author

bflad commented Dec 17, 2020

(rebased to remove merge conflict)

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@bflad bflad added this to the v3.24.0 milestone Jan 11, 2021
@bflad bflad merged commit 62c1d45 into master Jan 11, 2021
@bflad bflad deleted the d-provider-error-handling branch January 11, 2021 19:22
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants