Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout support for aws_sagemaker_project #25637

Closed
george-chenvibes opened this issue Jun 30, 2022 · 7 comments · Fixed by #25638
Closed

Add timeout support for aws_sagemaker_project #25637

george-chenvibes opened this issue Jun 30, 2022 · 7 comments · Fixed by #25638
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@george-chenvibes
Copy link

george-chenvibes commented Jun 30, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Deploying a Sagemaker Project takes a few minutes. But the creation of a project stops after 2m saying:
error waiting for SageMaker Project (data-ml-code-commit25) to be created: timeout while waiting for state to become 'CreateCompleted' (last state: 'CreateInProgress', timeout: 2m0s)

New or Affected Resource(s)

  • aws_sagemaker_project

Potential Terraform Configuration

resource "aws_sagemaker_project" "sagemaker_project" {
  name                 = "my-project"
  service_catalog_provisioning_details {
    product_id = aws_servicecatalog_product.example.id
  }
  timeouts {
    create = "30m"
  }
}

References

  • #0000
@george-chenvibes george-chenvibes added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 30, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Jun 30, 2022
@bschaatsbergen
Copy link
Member

bschaatsbergen commented Jun 30, 2022

@george-chenvibes instead of introducing a timeout configuration block I can increase the timeout from 2 to 15 minutes. Would that help solve your problem?

@george-chenvibes
Copy link
Author

@bschaatsbergen That will help. I'll see if it works after you increase the timeout.

@ewbankkit ewbankkit removed needs-triage Waiting for first response or review from a maintainer. labels Jun 30, 2022
ewbankkit added a commit that referenced this issue Jul 1, 2022
…aker-project-timeouts

Increase SageMaker `ProjectCreatedTimeout` and `ProjectDeletedTimeout` to 15 minutes
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 1, 2022
@bschaatsbergen
Copy link
Member

Hi @george-chenvibes, this has been merged and will be part of the next (v4.22.0) release.

@george-chenvibes
Copy link
Author

Hi @bschaatsbergen, do you know when that release will occur?

@bschaatsbergen
Copy link
Member

Hi @bschaatsbergen, do you know when that release will occur?

We just released, I reckon somewhere next week.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
3 participants