Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: ECS Service deployment alarms #28511

Closed
mkielar opened this issue Dec 21, 2022 · 4 comments · Fixed by #28521
Closed

[Enhancement]: ECS Service deployment alarms #28511

mkielar opened this issue Dec 21, 2022 · 4 comments · Fixed by #28521
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@mkielar
Copy link
Contributor

mkielar commented Dec 21, 2022

Description

Implement the possibility to configure Deployment Alarms in ECS Service.

AWS just released a feature in ECS allowing to configure custom CloudWatch Alarms, that the ECS Service Deployment will observe, and roll back the deployment if any of the alarm goes into an ALARM state.

Affected Resource(s) and/or Data Source(s)

  • aws_ecs_service

Potential Terraform Configuration

resource "aws_ecs_service" "example" {
  name    = "example"
  cluster = aws_ecs_cluster.example.id

  deployment_controller {
    # Note! ECS is currently the only supported controller for `deployment_alarms`. 
    # Pretty sure AWS will validate it, though.
    type = "ECS" 
  }

  # Potential new configuration
  deployment_alarms {
    enabled     = true
    rollback    = true
    alarm_names = [
      "my_custom_alarm_1",
      "my_custom_alarm_2",
    ] 
  }
}

References

  1. Announcement:
    https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-ecs-cloudwatch-alarms-safety-deployments/
  2. API:
    https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_DeploymentAlarms.html

Would you like to implement a fix?

No

@mkielar mkielar added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 21, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ecs Issues and PRs that pertain to the ecs service. label Dec 21, 2022
@bschaatsbergen
Copy link
Member

bschaatsbergen commented Dec 21, 2022

Hi @mkielar, thanks for raising this issue. I'll pick this up 👍

@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Dec 21, 2022
@github-actions github-actions bot added this to the v4.49.0 milestone Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants