Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeploymentAlarms to ECS Service #28521

Merged
merged 13 commits into from
Jan 4, 2023
Merged

Add DeploymentAlarms to ECS Service #28521

merged 13 commits into from
Jan 4, 2023

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Dec 21, 2022 •
edited
Loading

Description

Relations

Closes #28511

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccECSService_ PKG=ecs                                                                                             (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_'  -timeout 180m
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN   TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN   TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN   TestAccECSService_CapacityProviderStrategy_multiple
=== PAUSE TestAccECSService_CapacityProviderStrategy_multiple
=== RUN   TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN   TestAccECSService_renamedCluster
=== PAUSE TestAccECSService_renamedCluster
=== RUN   TestAccECSService_healthCheckGracePeriodSeconds
=== PAUSE TestAccECSService_healthCheckGracePeriodSeconds
=== RUN   TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN   TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN   TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== RUN   TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN   TestAccECSService_Alarms
=== PAUSE TestAccECSService_Alarms
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN   TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN   TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN   TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN   TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN   TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN   TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN   TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN   TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN   TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN   TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN   TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN   TestAccECSService_ServiceRegistries_changes
=== PAUSE TestAccECSService_ServiceRegistries_changes
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN   TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN   TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSService_LaunchTypeFargate_basic
=== CONT  TestAccECSService_ServiceRegistries_changes
=== CONT  TestAccECSService_Tags_propagate
=== CONT  TestAccECSService_alb
=== CONT  TestAccECSService_Alarms
=== CONT  TestAccECSService_executeCommand
=== CONT  TestAccECSService_clusterName
=== CONT  TestAccECSService_loadBalancerChanges
=== CONT  TestAccECSService_deploymentCircuitBreaker
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== CONT  TestAccECSService_DeploymentValues_basic
=== CONT  TestAccECSService_familyAndRevision
=== CONT  TestAccECSService_DeploymentControllerType_external
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
=== CONT  TestAccECSService_iamRole
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
=== CONT  TestAccECSService_multipleTargetGroups
=== CONT  TestAccECSService_Tags_basic
=== CONT  TestAccECSService_iamRole
    service_test.go:368: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 7b59ae71-f0ec-4458-998b-579a0c22b00c
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 11, in resource "aws_vpc" "test":
          11: resource "aws_vpc" "test" {
        
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
    service_test.go:425: Step 1/3 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 791c0d44-465b-4785-9866-7cbe18bd0d9d
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
=== CONT  TestAccECSService_loadBalancerChanges
    service_test.go:588: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 62ac8c7b-cb9d-4647-ac88-4a7d79199380
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
    service_test.go:324: Step 3/5 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 448fc5f4-22b5-4fe7-8ce3-640953b1e763
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 11, in resource "aws_vpc" "test":
          11: resource "aws_vpc" "test" {
        
--- FAIL: TestAccECSService_iamRole (28.81s)
=== CONT  TestAccECSService_renamedCluster
--- FAIL: TestAccECSService_loadBalancerChanges (29.06s)
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
--- FAIL: TestAccECSService_healthCheckGracePeriodSeconds (29.11s)
=== CONT  TestAccECSService_ServiceConnect_remove
--- FAIL: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (29.12s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_DeploymentControllerType_external (59.70s)
=== CONT  TestAccECSService_CapacityProviderStrategy_multiple
    service_test.go:239: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 0e6a3c79-fbc5-45a4-920e-03912b609da5
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 84, in resource "aws_vpc" "test":
          84: resource "aws_vpc" "test" {
        
--- FAIL: TestAccECSService_CapacityProviderStrategy_multiple (20.66s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
    service_test.go:1247: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 886fd581-794a-4773-b58d-dbec4b57e27c
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- PASS: TestAccECSService_DeploymentValues_basic (88.54s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_Alarms (88.60s)
=== CONT  TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_deploymentCircuitBreaker (88.73s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (88.93s)
=== CONT  TestAccECSService_forceNewDeploymentTriggers
--- PASS: TestAccECSService_familyAndRevision (90.90s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_executeCommand (94.56s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (0.88s)
=== CONT  TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_clusterName (98.14s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_basic (113.82s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
    service_test.go:984: Step 1/3 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: b2504563-6a7b-4fbc-960b-2bb2fa3d16d5
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- PASS: TestAccECSService_Tags_propagate (119.81s)
=== CONT  TestAccECSService_ServiceConnect_full
--- FAIL: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (22.19s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_Tags_basic (121.82s)
=== CONT  TestAccECSService_ServiceRegistries_container
--- PASS: TestAccECSService_renamedCluster (93.65s)
=== CONT  TestAccECSService_ServiceConnect_basic
--- FAIL: TestAccECSService_ServiceConnect_ingressPortOverride (102.03s)
=== CONT  TestAccECSService_ServiceRegistries_basic
=== CONT  TestAccECSService_LaunchTypeEC2_network
    service_test.go:1025: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: e441660f-64fa-41ae-8e61-8ba164f49871
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- FAIL: TestAccECSService_LaunchTypeEC2_network (23.13s)
=== CONT  TestAccECSService_replicaSchedulingStrategy
=== CONT  TestAccECSService_ServiceRegistries_container
    service_test.go:1146: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 09acb5bf-00a1-43bb-9ae6-f67fcac66b92
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- FAIL: TestAccECSService_ServiceRegistries_container (22.74s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== CONT  TestAccECSService_ServiceRegistries_basic
    service_test.go:1124: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 7e6f85cb-f29c-4cf9-a84f-49d0bda279b2
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (32.31s)
=== CONT  TestAccECSService_disappears
--- FAIL: TestAccECSService_ServiceRegistries_basic (22.88s)
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (79.28s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
=== CONT  TestAccECSService_CapacityProviderStrategy_update
    service_test.go:199: Step 2/4 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: 3ad9eaa7-8915-4dbb-a23f-45c84d32f594
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 101, in resource "aws_vpc" "test":
         101: resource "aws_vpc" "test" {
        
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
    service_test.go:951: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: e37a4577-2ac3-4f33-9ba0-897818e8cffa
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- PASS: TestAccECSService_LaunchTypeFargate_basic (173.37s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- FAIL: TestAccECSService_LaunchTypeFargate_waitForSteadyState (22.05s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (31.60s)
=== CONT  TestAccECSService_Tags_managed
--- PASS: TestAccECSService_PlacementConstraints_basic (87.77s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
    service_test.go:915: Step 1/3 error: Error running apply: exit status 1
        
        Error: error creating EC2 VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: f766348e-2e84-4116-90c5-4a7c6b51aa9a
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 12, in resource "aws_vpc" "test":
          12: resource "aws_vpc" "test" {
        
--- FAIL: TestAccECSService_CapacityProviderStrategy_update (112.61s)
--- FAIL: TestAccECSService_LaunchTypeFargate_platformVersion (22.07s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (110.39s)
--- PASS: TestAccECSService_forceNewDeployment (105.56s)
--- PASS: TestAccECSService_PlacementStrategy_basic (115.00s)
--- PASS: TestAccECSService_ServiceConnect_remove (179.41s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (84.05s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (232.52s)
--- PASS: TestAccECSService_alb (233.93s)
--- PASS: TestAccECSService_multipleTargetGroups (235.79s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (152.65s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (81.57s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (223.04s)
--- PASS: TestAccECSService_Tags_managed (83.74s)
--- PASS: TestAccECSService_ServiceConnect_full (179.60s)
--- PASS: TestAccECSService_ServiceRegistries_changes (300.79s)
--- PASS: TestAccECSService_ServiceConnect_basic (183.84s)
--- PASS: TestAccECSService_disappears (186.54s)
--- PASS: TestAccECSService_basicImport (203.89s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ecs        380.007s
FAIL
make: *** [GNUmakefile:92: testacc] Error 1

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. and removed service/ecs Issues and PRs that pertain to the ecs service. labels Dec 21, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 21, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 22, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review December 22, 2022 10:19
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 4, 2023
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 4, 2023
ewbankkit
ewbankkit approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSService_' PKG=ecs ACCTEST_PARALLELISM=3    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSService_ -timeout 180m
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN   TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN   TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN   TestAccECSService_CapacityProviderStrategy_multiple
=== PAUSE TestAccECSService_CapacityProviderStrategy_multiple
=== RUN   TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN   TestAccECSService_renamedCluster
=== PAUSE TestAccECSService_renamedCluster
=== RUN   TestAccECSService_healthCheckGracePeriodSeconds
=== PAUSE TestAccECSService_healthCheckGracePeriodSeconds
=== RUN   TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN   TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN   TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== RUN   TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN   TestAccECSService_Alarms
=== PAUSE TestAccECSService_Alarms
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN   TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN   TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN   TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN   TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN   TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN   TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN   TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN   TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN   TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN   TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN   TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN   TestAccECSService_ServiceRegistries_changes
=== PAUSE TestAccECSService_ServiceRegistries_changes
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN   TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN   TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSService_forceNewDeploymentTriggers
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSService_forceNewDeploymentTriggers (74.24s)
=== CONT  TestAccECSService_deploymentCircuitBreaker
--- PASS: TestAccECSService_basic (94.44s)
=== CONT  TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_deploymentCircuitBreaker (82.61s)
=== CONT  TestAccECSService_multipleTargetGroups
--- PASS: TestAccECSService_forceNewDeployment (82.53s)
=== CONT  TestAccECSService_alb
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (247.88s)
=== CONT  TestAccECSService_clusterName
--- PASS: TestAccECSService_clusterName (61.50s)
=== CONT  TestAccECSService_loadBalancerChanges
--- PASS: TestAccECSService_multipleTargetGroups (225.16s)
=== CONT  TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_alb (234.47s)
=== CONT  TestAccECSService_executeCommand
--- PASS: TestAccECSService_replicaSchedulingStrategy (61.09s)
=== CONT  TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_executeCommand (84.17s)
=== CONT  TestAccECSService_Tags_managed
--- PASS: TestAccECSService_loadBalancerChanges (200.79s)
=== CONT  TestAccECSService_Tags_basic
--- PASS: TestAccECSService_Tags_propagate (94.14s)
=== CONT  TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_Tags_managed (71.58s)
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
--- PASS: TestAccECSService_Tags_basic (117.74s)
=== CONT  TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_ServiceConnect_remove (162.86s)
=== CONT  TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (164.47s)
=== CONT  TestAccECSService_ServiceRegistries_changes
--- PASS: TestAccECSService_ServiceConnect_full (161.07s)
=== CONT  TestAccECSService_ServiceRegistries_container
--- PASS: TestAccECSService_ServiceConnect_basic (161.62s)
=== CONT  TestAccECSService_ServiceRegistries_basic
--- PASS: TestAccECSService_ServiceRegistries_container (167.38s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_ServiceRegistries_changes (251.61s)
=== CONT  TestAccECSService_iamRole
--- PASS: TestAccECSService_ServiceRegistries_basic (156.32s)
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
--- PASS: TestAccECSService_iamRole (66.68s)
=== CONT  TestAccECSService_renamedCluster
--- PASS: TestAccECSService_renamedCluster (81.33s)
=== CONT  TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_familyAndRevision (92.17s)
=== CONT  TestAccECSService_CapacityProviderStrategy_multiple
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (249.75s)
=== CONT  TestAccECSService_Alarms
--- PASS: TestAccECSService_CapacityProviderStrategy_update (335.34s)
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_Alarms (72.40s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (82.05s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_DeploymentValues_basic (82.17s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (27.99s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_LaunchTypeEC2_network (81.45s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (32.51s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (60.98s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (129.33s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (209.95s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (152.23s)
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_disappears (180.25s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (218.28s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (760.77s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_DeploymentControllerType_external (53.15s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (149.37s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_PlacementConstraints_basic (84.07s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_basicImport (196.08s)
=== CONT  TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (82.44s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.21s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_LaunchTypeFargate_basic (139.34s)
--- PASS: TestAccECSService_PlacementStrategy_basic (114.89s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (426.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	2467.984s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ec2b82f into hashicorp:main Jan 4, 2023
@github-actions github-actions bot added this to the v4.49.0 milestone Jan 4, 2023
@bschaatsbergen bschaatsbergen deleted the ecs-deployment-alarms branch January 4, 2023 20:46
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkielar mkielar mkielar left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.49.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: ECS Service deployment alarms
3 participants
@bschaatsbergen @ewbankkit @mkielar