Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesisanalyticsv2_application: Document support for FLINK-1_19 #38350

Conversation

nanohanno
Copy link

Description

Add documentation for supported Flink runtime 1.19

Relations

Closes #38348

References

The option was added in release v1.54.11

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@nanohanno nanohanno requested a review from a team as a code owner July 12, 2024 09:57
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/XS Managed by automation to categorize the size of a PR. labels Jul 12, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@nanohanno Thanks for the contribution 🎉 👏.

@nanohanno
Copy link
Author

You are welcome. I was confused by the documentation so I thought a fix might be helpful to others.

@ewbankkit ewbankkit merged commit 6d1f8b7 into hashicorp:main Jul 12, 2024
28 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 12, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Apache Flink version 1.19 in Amazon Kinesis Data Analytics
2 participants